warning: comparison between pointer and integer
suijingfeng opened this issue · 5 comments
https://github.com/OpenArena/engine/blob/master/code/renderer_oa/tr_model.c
code/renderer_oa/tr_model.c:202:11: warning: comparison with string literal results in unspecified behavior
if(ident == MDO_IDENT)
^
ident is a int, while MDO_IDENT is defined as a string in tr_mdo.h
#define MDO_IDENT "OPENMDL2"
MDO's meant to be removed. I didn't remove it out enough
It's sad that the author of MDO format disappeared from the forums without finishing it... :-(
http://openarena.ws/board/index.php?topic=5169.25
Wondering if someone may be able to look at what was done back then (there is something attached to this post) and continue the work from there...
Don't mislead into wasting effort on a format I don't plan to use....
Should tr_model_mdo.c be removed?
There are quite a lot warnings in tr_model_mdo.c, so if it is not needed then I would remove it as soon as possible.
REF_CC code/renderer_oa/tr_model_mdo.c
code/renderer_oa/tr_model_mdo.c: In function ‘R_LoadMDO’:
code/renderer_oa/tr_model_mdo.c:106:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
code/renderer_oa/tr_model_mdo.c:43:16: warning: unused variable ‘k’ [-Wunused-variable]
code/renderer_oa/tr_model_mdo.c: In function ‘R_AddMDOSurfaces’:
code/renderer_oa/tr_model_mdo.c:360:15: warning: unused variable ‘k’ [-Wunused-variable]
code/renderer_oa/tr_model_mdo.c: In function ‘R_GetMDOTag’:
code/renderer_oa/tr_model_mdo.c:585:11: warning: unused variable ‘trans’ [-Wunused-variable]
code/renderer_oa/tr_model_mdo.c:584:11: warning: unused variable ‘quat’ [-Wunused-variable]
code/renderer_oa/tr_model_mdo.c: In function ‘RB_SurfaceMDO’:
code/renderer_oa/tr_model_mdo.c:633:17: warning: variable ‘boneInfo’ set but not used [-Wunused-but-set-variable]
code/renderer_oa/tr_model_mdo.c:621:10: warning: variable ‘frontlerp’ set but not used [-Wunused-but-set-variable]