Consider a caching strategy for repo_to_installation_id_mapping

Question

Consider a caching strategy for repo_to_installation_id_mapping

Cadair opened this issue 6 years ago · 2 comments

That function uses a lot of GitHub API calls and takes a long time, it also probably doesnt change that often.

We should cache it and then either blow the cache away on a miss, or just try and extend the cache on a miss. The only thing this plan doesnt handle is how to remove an app from the cache if it is uninstalled on GitHub.

Answer 1 · 2018-07-24T22:22:46.000Z

As in #14 this https://pypi.org/project/expiringdict/#description might be useful here.

Answer 2 · 2018-07-31T10:29:08.000Z

This is a WIP by @Cadair here: https://github.com/astrofrog/baldrick/pull/17