Tag initial version
Closed this issue · 15 comments
I'd like to start using the publishing workflows in production but before doing that I think it would be good to tag a first version so we can @v1 to avoid any breakages.
Will we just go with semantic versioning and start at 1.0.0? Does @v1 include all 1.x.x releases?
Will we just go with semantic versioning and start at 1.0.0?
I think so 👍
Does
@v1include all 1.x.x releases?
Maybe not because actions/upload-artifact for example move the v_ tag to point to the latest v_._._.
Edit: accidentally pinged username v1 😆 Sorry!
I wonder if there is an existing GitHub action that will do that automatically?
Maybe we should resolve #9 (comment) before using tags?
Yes good point
I tried out https://github.com/marketplace/actions/update-major-version in ConorMacBride/install-package and it worked well. Just pushed the update_tag.yml, and then pushed a v1.0.0 tag and it created the v1 tag at the same sha.
fancy
Great!
Should we try and resolve #21 as the last point before we tag, since it would be a change of API effectively?
@ConorMacBride @Cadair - now that #21 is resolved, shall we go ahead and tag a first release here?
Yes 👍
@ConorMacBride - would you like to go ahead and do that? I guess we need to add the action for the auto-tagging first?
Okay, I'll add the workflow just like here: https://github.com/ConorMacBride/install-package/blob/main/.github/workflows/update_tag.yml
And then I'll push a v1.0.0 tag.
Done! 🎉 (Should probably disable PyPI upload in the tests so pushing a tag doesn't fail the tests: https://github.com/OpenAstronomy/github-actions-workflows/runs/5558235131?check_suite_focus=true)
Thanks! Close?