OpenCTI-Platform/connectors

[Ransomware] : broken code (hopefully) unreachable

Opened this issue · 1 comments

flavienSindou commented

Description

https://github.com/OpenCTI-Platform/connectors/blob/aa7299ade4a2d441109921188a4e4bd3adc8c6e6/external-import/ransomwarelive/src/lib/ransomConn.py#L81:L84

It seems that this part of the code contains an incorrect copy/paste. The code attempts to compare a string method, derived from a boolean, to a list of booleans:

isinstance(update_existing_data, bool) and update_existing_data.lower in [
            True,
            False,
        ]:
# update_existing_data => a bool?
# str.lower => a method definition, not a call
# in [True, False] => a check for one of the two possible boolean values

Fortunately, since update_existing_data cannot be a boolean (as it's retrieved from an environment variable), this part of the code is never executed.

Environment

  1. OS (where OpenCTI server runs): NA
  2. OpenCTI version: 6.3.6
  3. OpenCTI client: 6.3.6
  4. Other environment details: NA

Reproducible Steps

NA

Expected Output

NA

Actual Output

NA

Additional information

NA

romain-filigran commented

As "update_existing_data" is a deprecated notion, we have to remove any code related to this.