OpenEMS/openems

.vscode/settings is forcing format when saving, but editor.defaultFormatter is not specified.

miettal opened this issue · 4 comments

miettal commented

if a vscode user use another formatter (like prettier) as editor.defaultFormatter in user-side-config, the development will be difficult. because workspace-side-config force to run format and user-side-config formatter try to apply different styling policy.

I think, in case of forcing format when saving, specifiing workspace policy formatter as editor.defaultFormatter is better.

openems/ui/.vscode/settings.json

Line 3 in edfe1f0

"editor.formatOnSave": true,

sfeilmeier commented

@lukasrgr: Should we add editor.defaultFormatter?

miettal commented

now .eslintrc is in project directory(/ui) and developper following eslint rule, therefore I think "editor.defaultFormatter": "dbaeumer.vscode-eslint" is suitable.

  • 👍1
lukasrgr commented

@venu-sagar i think i saw this in your config

miettal commented

I tried to configure it in my local dev environment. it's working. how about this?
girasolenergy@6931885

// if this is ok, I can make a PR.

test