[BUG] - Does not work with Steam version

Question

[BUG] - Does not work with Steam version

qawasx opened this issue 6 months ago · 10 comments

qawasx commented 6 months ago

OpenKH Build
1104

OpenKH Program
OpenKh.Tools.ModsManager

Describe the Bug
The Mod Manager does not recognize Steam Folder Paths to the game exe as valid.

To Reproduce
Steps to reproduce the behavior:

Open OpenKh.Tools.ModsManager.exe
Click on game engine
Scroll down to PC release via Epic
entering steam Folder Location does not let me click next

Expected behavior
It should let me click next

Screenshots

Answer 1 · 2024-06-13T22:46:04.000Z

This is because the file this step of the setup wizard looks for is a dll that only comes with the EGS version of the game.
I am aware and will fix it but expect it to take time. I will not make a PR for 1 fix at a time so i need to rewrite sections of mod manager and test it for full compatiblity with both EGS and Steam release (not including Panacea/Mod Loader or LuaBackend These will need to be worked on by their devs).

Any bugs releated to Steam version will be expected for at least a month or more unless someone else finds time to fix it.

Answer 2 · 2024-06-13T23:43:50.000Z

Thanks for your reply. Take your time with this and thanks for providing this mod for us. The KH ReFined also must be updated probably.

Answer 3 · 2024-06-16T23:51:29.000Z

Fixed as of #1058. Please try build #1112 or later and report back.

Answer 4 · 2024-06-17T02:28:12.000Z

This allows some pieces of OpenKH (ver #1115) to work with the steam version of KH 1.5. It can correctly find the steam install paths and it seems to be able extract at least kh2 files at the end. However, trying to install panacea gives an invalid path error. Also, when I try to install a mod (A bunch of keyblades), using the build and patch command, I get an index out of bounds error (Though, I don't know if this is caused by OpenKH or the mod itself).

Answer 5 · 2024-06-17T03:10:18.000Z

Looks like PcReleaseLocation is never being set which is causing the Panacea install error. I'll be looking into that.

Answer 6 · 2024-06-17T03:21:41.000Z

Ah, PCReleaseLocation is specific to the EGS release atm. A jank hardcoded fix would be easy, but something more elegant should be doable without much trouble. Perhaps create a new variable for the EGS stuff and have PCReleaseLocation point to either it or Steam depending on the circumstances. Or even both at the same time. Just need to think about how to best structure things.

Answer 7 · 2024-06-17T04:00:31.000Z

That is similar to what I plan on doing when I can get to it.

Answer 8 · 2024-06-18T04:06:24.000Z

Should be fixed fully as of #1063. Please try release 1120 and report back.

Answer 9 · 2024-06-18T11:14:37.000Z

Seems to be fully working here! Thanks for your hard work!!! =)

Answer 10 · 2024-06-18T13:26:23.000Z

Thanks for your quick work!