OpenLake/WatchParty

Migration from manifest version 2 to manifest version 3

Closed this issue · 11 comments

mv2 is old version and The Chrome Web Store no longer accepts Manifest V2 extensions. That why it is not working.

Screenshot 2023-12-18 205721

I want to work on this assign it to me.

Migration to V3 is the main goal. This area needs some work as there have been significant changes in how service workers run in the background. Feel free to propose any ideas you may have to migrate to V3 while maintaining the original functionality.

@chaitanyabisht I am trying to set up the extension to work on my machine, it's not working.. is this the problem? or am I setting it up wrong?

@chaitanyabisht I am trying to set up the extension to work on my machine, it's not working.. is this the problem? or am I setting it up wrong?

The manifest V2 extension was working fine last year. Could you elaborate on the issue? Are you running the server as well?

Yes the server is running

image
First up I see this error when starting the extension.
And you don't see the Socket Status on the extensions as well (not connected to server etc)

I disabled the integrity check and added some logs to debug
image
The form definitely works and buttons are working, but nothing happens after form submission

the button onclick listener is sending a chrome runtime message, so added logs onto this runtime message listeners
image
image
and turns out the code never enters these blocks.
I added a bunch of other logpoints in functions like checkStatus which is being called, and socketStatus runtime message event listener that is responsible for the server status button , but No it never enters these blocks

can you check if its working for you? there's a chance I might have messed something up in the setup

How can I solve that problem when migration from mv2 to mv3

Screenshot 2023-12-19 173811 Screenshot 2023-12-19 173826

I don't know how to solve this problem . I tried many times.

@chaitanyabisht please look into it.

@gkm0001 are you able to get version 2 running or you are facing the same problem as me?

NO , I am not able to running version 2

I tested the extension and server with a fresh pull, and it is working. I can connect to the server, join rooms and chat. Although the seeking functionality isn't working right now, probably because of some change on YouTube's end.

@Snehil-Shah Check if the server is running, and check if your firewall or any other configuration is blocking access to the port 4000.

@gkm0001 Keep the manifest version 2 when testing, since it's still supported by Chrome right now, and will be deprecated soon.

OK