OpenLiberty/guide-microprofile-rest-client

Peer Review

Ahmad-Ayyoub opened this issue · 1 comments

  • Remove spaces in imports
  • Remove comments between imports
  • Remove commented codes
  • The RestClientTest.java test class is not showing up on README.adoc (check the tags).
    Can you table the annotations ?
  • InventoryManager is repeated ?
  • run diff -r start finish (There are some differences)
  • check if u need that much of you will ...
WARNING: You have 9 words of 'you will' in README.adoc file at following lines:
28
33
38
39
106
130
131
174
184

WARNING: You have 1 words of 'has been' in README.adoc file at following lines:
138

WARNING: You have 1 words of 'have been' in README.adoc file at following lines:
214

WARNING: You have 1 words of 'was' in README.adoc file at following lines:
78
  • META-INF is not created in start folder

  • Client test folder is not created in start folder

  • Check if some should follow the format.

WARNING: the `mprestclient-1.0` feature is also enabled in the `src/main/liberty/config/server.xml` file. this feature allows you to use the microprofile rest client to invoke restful services over http in a type-safe way. is not following the format.
WARNING: the code for the `system` service in the `src/main/java/io/openliberty/guides/system` directory is provided for you. it simulates a remote restful service that is not following the format.
WARNING: copy all the following code and replace the contents of the `src/main/java/io/openliberty/guides/inventory/client/systemclient.java` file: is not following the format.
WARNING: create the `src/main/java/io/openliberty/guides/inventory/client/unknownhostnameexception.java` file and add the exception class code: is not following the format.
WARNING: create `src/main/java/io/openliberty/guides/inventory/client/unknownhostnameexceptionmapper.java` file and add the mapper class code: is not following the format.
WARNING: create a configuration file `src/main/webapp/meta-if/microprofile-config.properties` and add a new config property `<fullyqualifiedinterfacename>/mp-rest/url`, which in this case is `io.openliberty.guides.inventory.client.systemclient/mp-rest/url`. is not following the format.
WARNING: then, update the `src/main/java/io/openliberty/guides/inventory/client/systemclient.java` file with a few more annotations: is not following the format.
WARNING: inject the `system` client to the `inventoryresource` class using cdi. copy all the following code and replace the contents of the `src/main/java/io/openliberty/guides/inventory/inventorymanager.java` file: is not following the format.
WARNING: copy all the following code and replace the contents of the `src/main/java/io/openliberty/guides/inventory/inventorymanager.java` file: is not following the format.
WARNING: create a `src/test/java/it/io/openliberty/guides/client/restclienttest.java` file and add the following code: is not following the format.

Format: Create a <class/type> in the `<path>` file: .
  • run Acrolinx and fix as needed (cant list 95 issues appeared)

screenshot 829

Code compiles and runs. Tests Passed

I have cross-checked with @JunyiSun regarding the above and the indentation as well. Approved