OpenLiberty/liberty-arquillian

Missing '/' before 'servers/' in WLPManagedContainer.java#L1440

bmarwell opened this issue · 0 comments

Offending line:
https://github.com/OpenLiberty/liberty-arquillian/blob/master/liberty-managed/src/main/java/io/openliberty/arquillian/managed/WLPManagedContainer.java#L1440

Issue Overview

It is common to define directories without a trailing '/'.

When setting ${liberty.install.dir}/etc/server.env containing a custom WLP_USER_DIR, then there will be a missing slash, resulting in a path like ${project.output.directory}/wlp-usrservers/servername/server.xml.

Same goes for defining an environment variable WLP_USER_DIR which has the same effect.

Expected Behaviour

one can define
WLP_USER_DIR=/dir

Current Behaviour

must have a trailing slash

Steps To Reproduce

When setting WLP_USER_DIR in ${liberty.install.dir}/etc/server.env
OR
env var WLP_USER_DIR

Additional Information

Offending line:
https://github.com/OpenLiberty/liberty-arquillian/blob/master/liberty-managed/src/main/java/io/openliberty/arquillian/managed/WLPManagedContainer.java#L1440