OpenMined/PSI

Go benchmarks are slow

Closed this issue · 0 comments

Description

Go benchmarks were found to be much slower than the C++ benchmarks. On closer examination, there are two issues with Go benchmarks:

  1. The setup code need to be moved out of the hot benchmark loop. Currently, the setup is counted in the benchmark time.
  2. Test assertions should be removed from the benchmark code. There are already many tests. Having tests in the benchmark would only slow it down.

If these two issues are addressed, then the Go benchmark should be much more accurate.

How to Reproduce

N/A

Expected Behavior

N/A

Screenshots

N/A

System Information

N/A

Additional Context

N/A