Template integration: feedback on organization_detail template
ryanpitts opened this issue · 8 comments
Definitely getting easier to do these as we get further into the process, @beep these modules are so good. Here's an example of an organization detail page to check out.
Only two things I'm noticing:
- We might need an alternate
.profile-photothat still floats to the right, but doesn't have theborder-radius(and can handle logos that are fairly horizontal) - The vertical alignment on the
p.has-iconin the "People" list, as noted in #61
yoooo, looking good. Here's the ProPublica profile with the updated logo handling.
Noting that extreme horizontal logos aren't ideal, e.g. New York Times. Not sure the best approach there, perhaps just an editorial policy of adding whitespace padding in the img itself?
yoooo, looking good. Here's the ProPublica profile with the updated logo handling.
dang, that looks great. thanks for kicking off these changes, @ryanpitts.
Noting that extreme horizontal logos aren't ideal, e.g. New York Times. Not sure the best approach there, perhaps just an editorial policy of adding whitespace padding in the img itself?
Hm, yeah. That’s tricky.
CSS-wise, the one thing that comes to mind is we could apply a border and some padding to logos. Here’s a quick sketch:
It’s a bit of a brute force treatment—some logos might not look great—but it’s an option.
My bigger concern is how we’d like to handle those logos on smaller screens:
Maybe something like this?
Added in 748b0a4!
(Let’s double check this fix when it merges? I had to make a minor structural tweak to .profile objects, which seems fine here, but holler if any regressions sneak in.)
Shall do!
Looks perfect to me.