OpenRA/vscode-openra-lua

Don't prompt to reload window

letmaik opened this issue · 6 comments

The Lua extension automatically picks up the generated files after a few seconds, so a restart isn't necessary.

How about removing this part?

const answer = await vscode.window.showInformationMessage(`There are unresolved map globals.`, 'Reload', 'Dismiss');
if (answer == 'Reload')
vscode.commands.executeCommand('workbench.action.reloadWindow');

LuaLS/lua-language-server#648 promised this was fixed so the nag screen could go away.

Sadly this is not the case
image

How odd, it really does work for me.

Extension.Development.Host.-.nod06b.lua.-.OpenRA.-.Visual.Studio.Code.2022-02-15.21-55-25.mp4

Strange. Is this a Windows vs. Linux file system thing?

I'm assuming it's not the filewatcher handle limitation since that should have led to a popup, but just in case:
https://code.visualstudio.com/docs/setup/linux#_visual-studio-code-is-unable-to-watch-for-file-changes-in-this-large-workspace-error-enospc

This was removed in #2 so let's give it a try.