OpenSLO/oslo

Should `Annotations` field use the `AnnotationType`?

kenfinnigan opened this issue · 1 comments

kenfinnigan commented

Summary

https://github.com/OpenSLO/oslo/blob/main/pkg/manifest/v1/objects.go#L93 has the Annotations field with a type of Labels. The definition of Labels is different to the definition of Annotations, and I was wondering whether that's intentional or should the Annotations field use the Annotations type?

Possible fixes

Can Annotations field to use the Annotations type instead of Labels.

programmer04 commented

Let's be consistent and do it the way proposed by @kenfinnigan

  • 👍1