OpenSLO/oslo

Validation fails with uppercase characters in label key

Closed this issue · 2 comments

Summary

Validation of label keys in metadata fails with an uppercase character in the name.

What is the current bug behavior?

SLO yaml with the following content will fail validation:

metadata:
  name: string
  displayName: string # optional
  labels:
    userImpacting:
      - "true"

What is the expected correct behavior?

Validation succeeds

Possible fixes

The check here can be removed to allow uppercase characters in the label key. As per https://github.com/openslo/openslo#general-schema it should be possible

@kenfinnigan is this still an issue? the linked line in the code moved so I wasn't sure if the behavior was still happening

Just tested with main and it's now fixed, thanks!