OpenSLO/oslo

Should spec tests be executed?

Closed this issue · 2 comments

Summary

Should the various SLO test files in /test be run when the project tests are executed?

Steps to reproduce

Run make run/tests.

What is the current bug behavior?

PASS
coverage: 61.8% of statements
ok  	github.com/OpenSLO/oslo/internal/pkg/validate	0.562s	coverage: 61.8% of statements
?   	github.com/OpenSLO/oslo/pkg/manifest	[no test files]
?   	github.com/OpenSLO/oslo/pkg/manifest/v1	[no test files]
?   	github.com/OpenSLO/oslo/pkg/manifest/v1alpha	[no test files]

What is the expected correct behavior?

Tests for spec versions are run.

@kenfinnigan I haven't done tests on specs before. What would those look like?

@ian-bartholomew apologies, looking at this now I realize I worded the problem poorly.

There are numerous SLO test files within https://github.com/OpenSLO/oslo/tree/main/test but because they were not showing in the test output I had assumed they weren't being used and that they should be.

However, looking at a test file in /internal I now see the test files are referenced from there in testing the code.

I think it can be closed