OpenTTD/website

Validation issues

andythenorth opened this issue · 3 comments

andythenorth commented

  1. WAVE toolbar reports 39 contrast errors for the home page, these are primarily in the layout templates, and will be present on most pages.

  2. WAVE toolbar reports accessibility failures on the download pages, primarily form labels missing.

TrueBrain commented

@andythenorth : do you plan to tackle these issues yourself? Otherwise you should really add more information about the issues :) This ticket currently is not fixable by anyone.

I have no clue what WAVE is. If WAVE is free to use, a link to this could be sufficient.

Basically: anything more than "something is wrong" would be appreciated :D

andythenorth commented

I am planning to fix these, but not a priority for me.

If anyone else wants to resolve them:

  • WAVE is a free validation tool from WebAIM https://wave.webaim.org/
  • I use it via the Chrome plugin
  • I run the OpenTTD website locally using jekyll serve, then check one page at a time
  • the contrast checker sometimes gives spurious failures, as it can't always resolve the css hierarchy to work out what the user will actually see rendered, but it's generally a pretty good guide, and I tend to fix the CSS so all the errors are resolved, it's usually not much work.

I also ran W3C html5 validator over the front page of the staging site: https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.staging.openttd.org%2F

This shows a couple of issues that are quite easy to fix.

TrueBrain commented

Seems the priority is this low, that it isn't being fixed ;) Going to close the issue now. If anyone wants to send in PRs, they are more than welcome!