OpenVisualCloud/SVT-VP9

ffmpeg_plugin is not compatible with n4.3

jbeich opened this issue · 6 comments

Only master applied against n4.3 before but now regressed by #119. From error log:

libavcodec/libsvt_vp9.c:32:10: fatal error: 'encode.h' file not found
#include "encode.h"
         ^~~~~~~~~~
1 error generated.

Hi @1480c1, the LIBAVCODEC_VERSION_INT checks were removed by @jamrial in #119 because it is unnecessary for master branch. May be we should make a new patch for n4.3 branch only?
Which solution do you think is better? Revert or add a new patch?

I think it may be better to revert in this case since we aren't planning to immediately upstream the svt-vp9 patches, so it would be better if we kept the contents of libsvt_vp9.c as close as possible between all of the patches to reduce maintenance burdens along with making sure that libsvt_vp9.c is at least not "wrong" in any branch.

It would probably also be best to not remove them until we decide to drop support for all tags other than the one that FFmpeg/FFmpeg@827d6fe is in (which is none of them atm)

VVD commented

It work with ffmpeg 4.3.1 now, thanks!
Can you create new tag v0.2.2?

@VVD , v0.2.2 tag is added.

VVD commented

Thanks!