Download Hardhat: add development network file to .gitignore
ericglau opened this issue · 7 comments
If Download -> Development Package (Hardhat) is used with Upgradeability, add the .openzeppelin/unknown-31337.json file to the resulting .gitignore (so that the development network file for the Hardhat Upgrades Plugin is ignored).
Also consider possibly different naming conventions depending on OpenZeppelin/openzeppelin-upgrades#645
I think you mean OpenZeppelin/openzeppelin-upgrades#465 ?
Both. If differently named files are written during tests, those should also be ignored.
Yes, though alternatively we should be writing network files in /tmp, which is mentioned in OpenZeppelin/openzeppelin-upgrades#465 as well. In that case there would be nothing to ignore. I think this is the ideal scenario.
Well, that said, for now Wizard should definitely include the current file in .gitignore.
This is no longer needed due to OpenZeppelin/openzeppelin-upgrades#726, because manifests for Hardhat dev networks will be written under /tmp instead.
Hi,
But this documentation should be updated to reflect this change, right?: https://docs.openzeppelin.com/upgrades-plugins/1.x/
I had to come across this issue to understand why I can't find the network file at the root of my Hardhat project anymore.
Hi @aashborn, thanks for pointing this out. We updated https://docs.openzeppelin.com/upgrades-plugins/1.x/network-files#temporary-files but missed that page. Could you please open a new issue?
By the way, could you let us know what is your use case that led you to look for that file for Hardhat?
My bad, I had missed this section! I had upgraded to a higher version of Hardhat and I was confused not to see this file anymore
Currently I would just like to use this file to study the variation of the storage layout. I know that this information can also be produced with the compiler options, but as I was saying I also wanted to know why I was not seeing the network file anymore.