Add `deploy_contract` to NRE
andrew-fleming opened this issue · 2 comments
andrew-fleming commented
The NRE only supports the old deploy
method: https://github.com/OpenZeppelin/nile/blob/main/src/nile/nre.py#L28-L48
For inspiration, see how cli.py handles both deploy methods: https://github.com/OpenZeppelin/nile/blob/main/src/nile/cli.py#L131-L153
martriay commented
The reason it was left out is because you should use the Account module (Account.deploy
), since vanilla deployments are deprecated. The snippet you link is meant to be removed very soon, when the tx type is fully disabled.
Maybe this is a documentation issue?
andrew-fleming commented
Ah right. No, I should know better. Still having the deprecated funcs and docs just threw me off.