Using C++11 instead of boost

Question

Using C++11 instead of boost

piratfm opened this issue 7 years ago · 8 comments

I have some small modifications, that allows to migrate from boost to C++11 this made for having possibility to compile modulator software for LEDE/OpenWRT, but it's not fully complete (especially for telnet remote control and USRP driver), maybe it will be interesting to finalize it, so embedded devices will have less dependencies.

Here is diff on how it can be done:
piratfm@6dc0cdf

Answer 1 · 2018-01-31T14:49:40.000Z

Replacing boost with std is welcome, but I'm unhappy about std::thread missing the interrupt() functionality. On my system it is actually necessary otherwise it will not stop properly. It has to be replaced by another way to wake up the sleeping thread.
I have a long flight on the 3rd, I'll look into it then. Of course, feel free to push more commits to your boost_to_cpp11 branch, I will follow it (No need to open a new pull request).
Thanks!

Answer 2 · 2018-01-31T15:09:27.000Z

Since we already having dependency for posix threads, i'm thinking we can use it for creating threads that must have possibility to cancel like pthread_create() and after that pthtead_cancel(), so exception like in boost will be catched. Just not sure if all of threads must be cancelable.

Answer 3 · 2018-01-31T16:00:18.000Z

Not all need to be cancelled. I've already converted most to std, except those that used interrupt(). I guess we can call pthread_cancel on the std::thread native handle, boost is probably doing the same. I wonder however how the cancellation itself gets done, maybe we need to do something special inside the thread function. I'm OK with assuming pthread, if one day we have to support another thread implementation we'll take care of it then. PS: License.txt from the INI lib needs to be added. Could you put into lib/ instead of /src to distinguish between our code and 3rd party code?

Answer 4 · 2018-02-01T02:49:50.000Z

branch boost_to_cpp11 is now in this repository too, and you have push rights. We can complete this work here.

Answer 5 · 2018-02-01T03:56:56.000Z

My assumption that boost uses pthread_cancel was wrong, I checked the boost sources. I am currently wondering "how could it have worked?", and I will have to look into it further.

Answer 6 · 2018-04-16T07:15:58.000Z

Review of goals: instead of removing boost completely, make boost optional when building ODR-DabMod for the EasyDABv3, which has part of the processing done in FPGA.
This will happen in next and the branch boost_to_cpp11 will not be used anymore.

Answer 7 · 2018-04-17T14:24:34.000Z

Branch easydabv3 now compiles without boost.

Answer 8 · 2018-08-06T08:36:51.000Z

ODR-DabMod next does not require boost anymore, and the telnet server should now also work for the easydabv3 build, although I didn't try.