Replace Modal Component with Radix UI's Dialog

Question

Replace Modal Component with Radix UI's Dialog

kylemh opened this issue 3 years ago · 5 comments

We have and use a Modal component in a few places.

No real issues with react-modal that I'm aware of, but I'd rather use Radix for most/all primitives.

This ticket is to replace our Modal component and re-implement a styled instance of Radix UI's Dialog and update any stories and integration tests. Feel free to remove unit tests.

Answer 1 · 2022-03-19T18:35:01.000Z

Hi! May I work on this issue?

Answer 2 · 2022-03-19T20:54:46.000Z

Absolutely!

Answer 3 · 2022-04-05T15:01:46.000Z

Hi - sorry it took me so long to get started on this! I had a quick question - is the goal to replace each instance of the Modal shared component with the Radix Dialog, or to replace the actual ReactModal within the shared component with a Dialog instance? I was assuming the latter, but I just wanted to check.) Thanks!

Answer 4 · 2022-04-05T15:21:13.000Z

I'd suggest replacing the shared component. The goal would be to have no react-modal imports.

Answer 5 · 2022-04-10T19:43:49.000Z

Hi again! So I'm running into a weird issue where the "join" Cypress tests are failing on GitHub, but all the tests are passing locally. I don't think anything I modified in this PR relates to the account registration so I'm not really sure why it's failing - would you happen to have any tips? Thanks!