Cart vanishes when the shell is restarted (OCC-276)
Opened this issue · 2 comments
Describe the bug
If you have items in the cart, a shell restart will wipe it out. This is an issue because configuration changes, deployments can cause the shell to restart at any time, but this disrupts shopping and causes the shop to lose money.
To Reproduce
- Launch the latest
main(9d3d685). - Add something to the cart.
- Enable any feature. For the sake of simplicity, I enabled the harmless Background Tasks one.
- Observer that after a refresh on the frontend, the contents of the cart are gone.
Expected behavior
The cart remains after a shell restart too.
Screenshots
2024-08-01_23h08_05.mp4
This is not a bug. The reference implementation of IShoppingCartPersistence is SessionShoppingCartPersistence. This serializes the cart contents into HttpContext.Session, which is volatile storage that's lost when the application closes.
The advantage of this temporary storage is both ease of implementation and not having to worry about invalidating and periodically cleaning up abandoned carts (otherwise abandoned carts could accidentally or maliciously eat up the site's database space). The disadvantage is what you described. However config changes and deployments shouldn't happen so often where this becomes a realistic problem in everyday use, so session storage remains a suitable default.
Web developers using OCC can implement their own IShoppingCartPersistence which uses site setting, an external database, etc for persistent storage. A purely client side storage is also an option. We may add a different implementation as a feature in the future. The added complication and the unclear demand makes me less convinced that this should be a priority. But if desired, please convert this from bug to a feature issue.
Really every user-facing feature needs to be resilient so shell restarts in an OC app (as it is with the OOTB features, like user logins remain, and you can edit content items without disruption), since a shell restart is not at all uncommon. It happens e.g. in the following scenarios:
- A lot of site settings and other configuration changes restart the shell apart from turning features on or off.
- On DotNest, we shut down idle tenants. If you start shopping, get up to do whatever, then come back later to finish it, you might hit a now newly starting shell.
- In an actively developed app deployments and prod rollouts can happen daily, or even multiple times a day. (There are periods like this in our apps too.)
And furthermore, horizontal scaling should be possible to support as well.
I don't think the current implementation is really appropriate, then.