Missing translations from .cshtml files
agriffard opened this issue · 6 comments
With the latest prerelease (https://www.nuget.org/packages/PoExtractor.OrchardCore/0.3.0-beta3-71077) or release (https://www.nuget.org/packages/PoExtractor.OrchardCore/0.2.0) versions of the dot net tool, some tanslations in .cshtml files are not generated when we execute :
extractpo-oc D:\Orchard\OrchardCore C:\temp\OrchardCore --liquid
Ex: It removes the strings that exist in .cshtml files in OrchardCore.Admin and many others.
Can you please have a look @lukaskabrt ?
@hishamco removed T accessor in PR #25 because according to OrchardCMS/OrchardCore#5182 (comment), there should be a new convention for names of localizer accessors.
If T is still used in some places, I can add it back ...
Yes, please readd it, it is still used everywhere.
I think I remove them from code not the view, let me double check again
Yes, please readd it, it is still used everywhere.
My suggestion to fix it in OC because we already started this, furthermore we can create a code analyzer to fix such issue
If sound is good I can start work on it, meanwhile I can scan entire OC source to remove the inconsistent localizer names
I added T back in #32. If it is removed from OC, it can be removed from PoExtractor again.
Thank you @lukaskabrt