Technical debt: property _ignoredProjects is no longer in use
Closed this issue · 3 comments
https://github.com/OrchardCoreContrib/OrchardCoreContrib.PoExtractor/blob/main/src/OrchardCoreContrib.PoExtractor/Program.cs line 17 is no longer used and can be removed:
IgnoredProject seems to have taken over this responsibility.
It might be an option to put the default ignored projects in appsettings.json and use IConfigurationBuilder. The IConfiguration also supports command line arguments, so you could find the settings in the same store.
Notice the challenge when locating the settings file dotnet/sdk#9730.
Don't forget it's a CLI tool, that's why I'm thinking of adding it as option
Exactly: you could store the default in de appsettings.json and override it via de commandline. When you first add the .AddJsonFile and after that the .AddCommandLine the last one takes priority.
But you are right: too much fuzz to add IConfiguration just for a command line parameter which has a default and which you will be able to override....