Nonunique subheadings link incorrectly
Closed this issue · 9 comments
There is a fix for this in the lord/slate master branch. @wanderingstan is there a convenient way to fast-forward our branch to include some of their changes, or would you like me to make a PR with the NestingUniqueHeadCounter class manually added? I've tested and it fixes our problem.
Can we just copy their code over, and make a single commit here with the latest slate stuff?
Also, issue gif is the best thing since sliced bread.
@wanderingstan is going to see about pulling upstream commits in conjunction with deploying #16.
I think I got the changes from lord/slate merged in but am not seeing the linking behavior fixed.
Work is in branch: https://github.com/OriginProtocol/docs/tree/issues/15
The new NestingUniqueHeadCounter class is there. @micahalcorn did you confirm that adding this class (and the other minor file update) fixes the issue?
I cherry-picked the branch from lord/slate and merged our changes into it.
@wanderingstan 8e64720 thanks!
Done and deployed! http://docs.originprotocol.com/#purchase-get
@micahalcorn is there a tool for making issue gifs?? I now feel like a caveman over here banging keys on my keyboard.
@wanderingstan I just use GIPHY Capture, save, and drag into the comment box. There may be an easier way.
Thanks! @micahalcorn
