OrleansContrib/Orleans.Providers.MongoDB

Investigate compatibility with Orleans v4 preview

jeremylcarter opened this issue · 20 comments

jeremylcarter commented

I think we should investigate compatibility with the breaking changes coming in Orleans v4.

I have forked the repository and will see what work is involved.

jeremylcarter commented

I have done the major legwork to target .NET Core 3.1 and Orleans v4.

https://github.com/jeremylcarter/Orleans.Providers.MongoDB/tree/feature/orleans_v4

I was unable to get the unit tests to work , due to lack of understanding how they are wired up with the included lib dll's. The integration test works, and passes however.

SebastianStehle commented

Thanks for your work.

Many important test classes are not available as nuget package, therefore I just built Orleans myself and added everything to the libs folder.

Created an issue for that: dotnet/orleans#7817

jeremylcarter commented
SebastianStehle commented

Yes, exactly. it sucks, but I think it is better than writing these tests manually.

jeremylcarter commented
jeremylcarter commented

@SebastianStehle I will need some help getting the tests organized.

SebastianStehle commented

How is it going?

SebastianStehle commented

In the current branch the tests were actually not running. I fixed that.

jeremylcarter commented

I'll sort out a branch this week and collaborate with you if you're keen. Thanks.

  • 👍1
MarkusGeigerDev commented

How are things going, folks? I also had a quick look and made quite a progress after yesterdays release of Orleans 7 but then I stumbled across the same issue with the ./libs.
@jeremylcarter: Should we work together to get this up and running for Orleans 7? I would even considering stepping in as a (co-)maintainer for this package.

  • 👍1
SebastianStehle commented

How are things going, folks? I also had a quick look and made quite a progress after yesterdays release of Orleans 7 but then I stumbled across the same issue with the ./libs.

We could just use a git submodule and import the necessary project files into the solution.

I would even considering stepping in as a (co-)maintainer for this package.

I am not using Orleans anymore so I would really appreciate that.

MarkusGeigerDev commented

We could just use a git submodule and import the necessary project files into the solution.

Good idea. Could you help to prepare that?

I would even considering stepping in as a (co-)maintainer for this package.

I am not using Orleans anymore so I would really appreciate that.

Yeah, I read about that in the other issue. I'm on the other hand am just getting deeper into it and I am definitely interested in keeping the MongoDB support alive :)

SebastianStehle commented

Good idea. Could you help to prepare that?

I can have a look, but I guess it would be a good first issue for you as well ;) ...

so

  1. Import libs from submodule
  2. Create 3.X branch
  3. Work on 4.X migration
jeremylcarter commented
jeremylcarter commented
  • 👍1
SebastianStehle commented

Just create a PR and I can help and review

MarkusGeigerDev commented

My branch is here: jeremylcarter/Orleans.Providers.MongoDB at feature/orleans_v4 (github.com)

Thanks!
I'm looking through your changes and comparing them to mine. It seems like there were a few breaking changes between v4-rc and v7 and I'm trying to kind of merge what you did with my changes. I suggest that I will push my branch when I'm ready and then let's decide what to bring forward as a PR.

MarkusGeigerDev commented

@jeremylcarter
Here's my port: https://github.com/MarkusGeigerDev/Orleans.Providers.MongoDB/tree/Orleans_v7
I still didn't get the unit tests to work - I will probably try Sebastian's suggestion with the submodules later

SebastianStehle commented

I have created a PR to visualize the changes.

  • 👍1