Support an IGRINSSlit class
gully opened this issue · 2 comments
In PR #136 I pitched the prospect for an IGRINSSlit class, and provided a sketch of what methods could reside there. I think this is a good idea, and we should talk about it. Currently housing all those functions on top of IGRINSSpectrum objects seems out-of-place, since most of those functions are operating on a distinct data product.
I think this devoted IGRINSSlit class would also alleviate the tension we felt in #138.
This is a good idea. I think it should be generalized so muler can use it for other slit spectrometers. I've built a Slit class and put it in utilities.py. Not sure if this is the best place for it, but it works for now. You can see what I've done in PR #136.
Nice! I think the best path forward is to pair-code on this. We should move it from utilities.py to either a standalone slit.py or scene.py.