Oxlac/AI-News-Summariser

Any link inputted gets summarized.

Aadityaa2606 opened this issue · 2 comments

bug Description
The issue is if we input any link (eg. www.google.com) the summariser thinks it's an article link and summarises it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://aisummariser.oxlac.com/ or clone and run the local dev environment.
  2. copy and paste a nonrelevant link.
  3. click on go.
  4. see the non-relevant summary.

Expected behavior
Prevent accepting irrelevant links, if the user tries to submit an irrelevant link then show them an error similar to this

image

Bug Screenshots
bug

Possible approaches

The fix proposed by @rnavaneeth992 is a really good approach but not quite feasible for every irrelevant link, so I am reopening the issue back for other contributors to make additional improvements to the detection system on top of the existing approach!

Explanation of the Fix:

  • The previous fix added a try-catch block after querying the URL, the try-catch block Raises an HTTP error if the HTTP request returned an unsuccessful status code. which means if the link didn't give any HTTP error it doesn't detect the link is irrelevant

  • There was also a second check placed that if the summary content is 0, it predicts the URL as invalid.

Additional improvements that can be made: