Misc minor bugs
Closed this issue · 14 comments
"I found another (minor) problem with the quotes, while installing
PGPLOT. Maybe not directly related to PDL, but as it is mentioned in
the DEPENDENCIES I bring it up here.
After downloading PGPLOT,
perl Makefile.PL
yields the message
Unrecognized argument in LIBS ignored: '"-L/usr/lib/gcc/x86_64-linux-gnu/8"'
Anyway,
make
works.
make test
fails in perl 5.28 as '.' is not in @inc, but it passes after editing
test.pl, replacing "test..." by "./test..."
Best regards,
Luis"
At the top:
use Cwd 'abs_path';
On now line 39:
do abs_path("test$jjj.p");
If you can bear to transfer the repo to PDLPorters, I'll take care of it now. And if you want to give co-maint, I'll even release the updated version!
Correctly indeed!
The tests now work, yay.
I've taken the liberty of importing the "GitPAN" history for this, and carried across all the changes made on top of 2.21: the Makefile.PL tweaks, plus my adding just now of test fixes plus .gitignore.
To sync your repo with this, do:
git fetch # not pull, that will cause lots of noise
git checkout master # in case you're not there already
git reset --hard origin/master
In case it's needed (it won't be), I've copied the previous master to oldmasterwithlesshistory. In case of utter catastrophe locally (there's no file-difference except a missing .hgtags), you can just delete and re-clone from this and all will be well.
When you're happy, feel free to close this issue!
Whatever you find easiest! But if you try it here, you can easily fall back to good old rm.
I've also pushed one more update with repo metadata. What are your thoughts on a CPAN release? I'm happy to do it if you're happy to add me as co-maint, or I'm equally happy if not (as that's less work).
Oops I forgot to reply to this!
Let's do a release, I will add you as co-maint.
"Co-maint" in Perl-land always refers to PAUSE/CPAN, as you say. I'm ETJ. Let me know when done and I'll push this out!