minio client (un)necessary?
Closed this issue · 1 comments
WouterVisscher commented
Seeing that the atom-generator 'only' (?) needs to know the length & type (content-type) from the file it will "atom". This information could also be retrieved without the use of a 'heavy' S3 client (like minio) with the additional needed configuration/parameters. A 'simple' http/curl-like request would be sufficient, this would also 'double' as a health-check for PASSING/FAILING the creation of the ATOM files. This health check is now also there, but could fail. 'Cause the S3 credentials are allowed to acces the file, but a anonymous HTTP call from the lighttpd service (that the atom-operator creates) could be 'blocked'
WouterVisscher commented
refactor done with: https://github.com/PDOK/atom-generator/tree/atom-generator-2