bugs in gen_installer.sh
larvata opened this issue · 2 comments
larvata commented
Some bugs prevent the script from working correctly when the user specifies arguments.
- Wrong usage example in doc:
docker run -v $(pwd):/root/workspace tdmelodic:latest \
bash /tmp/script/gen_installer.sh \
--neologd=${NEOLOGD_SRC_DIR} \
--unidic=${UNIDIC_ZIP} \
--dictionary=${TDMELODIC_CSV}
->
docker run -v $(pwd):/root/workspace tdmelodic:latest \
bash /tmp/script/gen_installer.sh \
--neologd ${NEOLOGD_SRC_DIR} \
--unidic ${UNIDIC_ZIP} \
--dictionary ${TDMELODIC_CSV}
-
The $YMD is incorrect when the user specifies the $NEOLOGD_DIR
$YMD should be generated after the user-specified arguments are handled. -
The option "--ymd" does not work, this argument shouldn't be processed with "readlink"
-
The script "script/gen_installer.sh" doesn't have the execution permission, in my experience, it is safe to set the execution permission in the repository.
tachi-hi commented
Thank you! I'll check that.