material-extensions/vscode-material-icon-theme

Why is the Golang icon now square?

Closed this issue · 9 comments

eduardo-mior commented

Describe the bug
Golang icon is no longer rounded, it is square, it is no longer the original GO icon.

Expected behavior
I expected the official, original rounded icon.

Screenshots
go.dev official golang icon
image
new icon
image
image

Additional context
I would like to know and understand why the golang icon was modified, from my point of view it doesn't make any sense.

BrunoKrugel commented

Even the Go icon from the sources link is rounded

https://pictogrammers.com/library/mdi/icon/language-go/

PKief commented

We tried to design an SVG icon which is better fitting into a 16x16px grid system. The reason for that was to make the icon more sharp and not blurry on its edges. Let me evaluate if that was a good decision or not, otherwise we can also rollback the original icon.

BrunoKrugel commented

Here is the old one:
image

Here is the new one:
image

It seems dislocated and "too squared" if compared to others

ndbeals commented

I too was surprised by this change and would prefer to use the old icon myself.

I was able to restore the old icon by following the custom icon instructions in the README downloading the icon from here and setting this in the user settings.json

    "material-icon-theme.files.associations": {
        "**.go": "../../icons/go",
    },
  • 👍6
PKief commented

@lucas-labs I was wondering if you have an idea of how we could make the GO lang icon still be fitting better into a 16x16 grid and have the icon a bit more similar to the original logo?

lucas-labs commented

Hey there!

Yeah, that one was one of the icons I mentioned that I had made some highly opinionated changes to it in my fork. I use golang quite a lot myself and since I refuse to use my glasses 😅, the old icon was too blurry for me after a few hours. But I also agree that the result is not optimal and I was thinking of changing it in my fork too. Let me explore some alternatives to see how it goes

  • 👍1
lucas-labs commented

Ok, I tested the ideas I had in mind but honestly, I think I just prefer the old one.
What I didn't like of the original one was that the 3 lines in the left when reduced to 16px became a single line of pixels and was imposible to see that it was actually 3 lines.

image

But in retrospect, I don't think it's as important as keeping the original shape of the GO logo.

(pink mark is the old/original golang icon)

16px

image

32px

image

@PKief, those are the ideas I tested, but I think there was not noticiable improvements imo, and the original one is already easily recognisable.

  • 👍1
PKief commented

@lucas-labs Thank you very much for providing some ideas here. Personally, I like the third solution. It does not look too blurry but is still recognizable and very similar to the original GO logo:

image

I think your opintionated icon (the first one) definitely is the sharpest version but it's still very opinionated and maybe not the best option here. Do you think it would be fine if we change it to this third solution?

lucas-labs commented

@PKief sure, I'll send a PR

  • 👍3