[Icon Request] workflows
Closed this issue · 7 comments
Icon Type
- Folder
- File
Folder Names
- "workflows": "pipe"
Additional context
I think the workflows folder (in .github for example) should have the pipe icon associated.
I've created this two icons in my fork. If Pkief likes them, I could send a PR
They use an icon which is similar to the one Github uses in its extension:
Although, I was thinking on changin the folder icon to use the same colors as the current github folder
There's a problem with this though, as far as I know, folder-name/extension associations only supports one level of deepness. So although we can associate workflows/yml we cannot associate .github/workflows/yml. Which means that any yaml file inside a folder called workflows will have the icon, not only those inside a .github folder.
@lucas-labs It's a nice idea and I also like the icon. As vscode API does not support folder-x/folder-y/yml I think it's better to keep it consistent with the plain yaml icon. We should not overengineer it at this point. People might be wondering why their icon in their workflows directory does not have the typical yaml icon if it's not located in a .github directory.
And that's why JetBrains products are superior 😎
The GitHub Actions extension introduces the github-actions-workflow language ID for its workflow files. How about at least associating an icon with it?
The GitHub Actions extension introduces the
github-actions-workflowlanguage ID for its workflow files. How about at least associating an icon with it?
Sounds good, thanks for the update. I think we can add an icon for the language id, @lucas-labs what do you think?
Sounds good, thanks for the update. I think we can add an icon for the language id, @lucas-labs what do you think?
Yes, that sounds great, I'll create a PR!