PM-Master/PMAdminTool

Graph Editing Bug

dyiop opened this issue · 1 comments

dyiop commented

Steps to recreates:

  1. Switch back and forth grid ↔ graph view.
  2. While on grid view, make a change to the graph.
  3. Now, when you go back to the graph view, there is no graph.
    • There is a graph, it just cannot be seen! For some reason it zooms in and pans
    • Doesn’t contain most recent change?
      • Graph is loading version of the data from last time it was viewed
        • so if you make multiple changes while on grid view, it will only keep the one from when you last loaded it

Potential causes:

  • How I made it hide, and the show the graph on toggle (vs redrawing graph everytime)
  • Reset view function in JS code
dyiop commented

Here you can see that invisible components don't get updates from the server.

Fix: While graph is invisible, maintain a flag for pending changes. Once we toggle it to be visible, call reset, and update flag.