Pallinder/go-randomdata

Title with RandomGender generates firstname instead of Title

marcofranssen opened this issue · 3 comments

marcofranssen commented

See below the bug in default switch.

// Title returns a random title, gender decides the gender of the name
func Title(gender int) string {
	var title = ""
	switch gender {
	case Male:
		title = randomFrom(jsonData.MaleTitles)
		break
	case Female:
		title = randomFrom(jsonData.FemaleTitles)
		break
	default:
		title = FirstName(privateRand.Intn(2))
		break
	}
	return title
}
Pallinder commented

Thanks for this! Think you could open a PR so we can fit into release 1.2.0?

daisy1754 commented

Hi @Pallinder I've opened #64 to fix this. Do you mind taking a look (also it'd be great if you can look at #63 too :) )

  • 👍1
Pallinder commented

Released in v1.2.0