Palm-Tree-CSS/palm-tree-css

Update fonts variable name

adonyssantos opened this issue · 9 comments

adonyssantos commented 
          This variable name is so generic. I think that we will create a more descriptive variable name, like `$font-body`, `$font-headings`, etc.

Originally posted by @adonyssantos in #40 (comment)

joer9514 commented

why do you want a different font-family for body and headers?

joer9514 commented

I think variable names, directly related to properties like font-family, should have the same format: $font-family and keep this structure in all others.

  • 👍1
adonyssantos commented

I think variable names, directly related to properties like font-family, should have the same format: $font-family and keep this structure in all others.

But you can have more than one font-family, so $font-family is so generic. For example: we can have fonts for the code blocks, headings, body, etc. Even if is the same font for all of them, it's a good practice to have different variables.

Xansiety commented

I think variable names, directly related to properties like font-family, should have the same format: $font-family and keep this structure in all others.

But you can have more than one font-family, so $font-family is so generic. For example: we can have fonts for the code blocks, headings, body, etc. Even if is the same font for all of them, it's a good practice to have different variables.

Do you plan for each element to have a different typeface?

  • 👀1
adonyssantos commented

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".

For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.

Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;
  • 👍1
Xansiety commented

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".

For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.

Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

adonyssantos commented

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".
For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.
Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

If you like you can work on it

  • ❤️1
Xansiety commented

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".
For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.
Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

If you like you can work on it

Glad to contribute to the project!

  • ❤️1
adonyssantos commented

Do you plan for each element to have a different typeface?

Not all the typefaces, but for some group of typefaces the answer is "yes".
For example:

  • $font-base for * (all tags - it's the base font).
  • $font-heading for all h-tags (from h1 to h6).
  • $font-buttons for buttons.
  • $font-code for code, pre and kbd.
  • $font-body or maybe $font-content for all p, a, strong, i, em and all other tags related with content.

This doesn't mean that each of these will have different fonts (the same value can be used for each of these). Although we can do it this way to give the user more customization options.
Implementation example:

$font-base: system-ui, sans-serif;
$font-heading: $font-base;
$font-buttons: $font-base;
$font-code: "Fira Code", $font-base;
$font-content: $font-base;

ok, that sounds pretty good for organizing everything

If you like you can work on it

Glad to contribute to the project!

Check our CONTRIBUTING.md and send the PR to the release/2.0.0 branch.