LICENSE missing for sdist
Closed this issue · 3 comments
The LICENSE file is still missing from the sdist 0.3.1 on pypi.
I'm not sure why. New versions of setuptools should automatically include it. If I run pyproject-build locally in the repo, the LICENSE is included.
Was the version uploaded to pypi created differently?
The version uploaded to PyPi is built in our Github CI here. I'm afraid I have no idea why a licence file isn't being added. @coretl any ideas?
The issue is probably the pinned early versions of setuptools to keep compatibility with our internal build process. As we don't need to do that for this particular module then I think we can safely update. For best results, maybe we should adopt https://github.com/DiamondLightSource/python3-pip-skeleton when @gilesknap has finished the latest round of updates
I just checked 0.7.0 and the file is present. Was maybe before (probably at least since you switched to setuptools_scm). Anyway, closing this!