Pandarix/BetterArcheology

Crash at worldgen

Closed this issue · 8 comments

Game crash at worldgen.

https://mclo.gs/LKFxRoc

java.lang.IllegalAccessError: failed to access class net.minecraft.world.entity.npc.VillagerTrades$TreasureMapForEmeralds from class net.Pandarix.betterarcheology.event.ModEvents

Seems like the accesstransformer.cfg is not properly loaded. It should grant access to the class.
I'll look into it. For replication: Are you using a custom modpack or could you give me a name?

Could not replicate with Forge 1.20.1 and Betterarcheology alone.
There must be an incompatibility with a mod or other problem within the pack you are using.

Better archeology 1.1.5 works great.

Ran Into this issue as well. Appears to be an incompatibility with Pneumaticcraft, specifically, its amadron tablet list generation for trades. I was able to reproduce with only Better Archeology, Pneumaticcraft, and the required mods installed. Can also confirm this was not an issue in Better Archeology 1.1.5

Crash report
Latest Log

Versions:

  • Minecraft: 1.20.1
  • Forge: 47.2.20
  • Better Archeology: 1.1.6
  • Patchouli 1.20.1-84
  • Pneumaticcraft: 6.0.14
  • Yung's API 4.0.4

Thanks for the hint for the incompatibility! I'll look further into that :)

It seems like an issue like this already occurred once.
The AmadronOfferManager from PneumaticCraft seems to be the cause of this issue.

Although I don't have enough time to dive deep on this right now and there may be a different cause, I would suggest opening an issue there as the class I linked above already had an issue similar to this one in the past.

Taken from the getOfferForNullVillager class inside AmadronOfferManager.java:

creating a fake villager can cause worldgen-related server lockups
TeamPneumatic/pnc-repressurized#899

For reference, I've tried using MoreVillagers along with Pneumaticcraft and it seems to work.
Maybe I'll just have to give my TradeRegistration a quick do-over. 😰

Fix [1.1.7] is available on:

Modrinth
CurseForge
Thank you for reporting!