ListRepresenter, Representer and ArrayRepresenter should be in same file

Question

ListRepresenter, Representer and ArrayRepresenter should be in same file

driescroons opened this issue 3 years ago · 3 comments

driescroons commented 3 years ago

I feel like we should the representers in 1 single file with different exports. They're small files, so why not?

driescroons commented 3 years ago

cleanup

Answer 1 · 2022-03-17T13:29:47.000Z

What's the benefit?

Answer 2 · 2022-03-18T10:35:46.000Z

Goes against the general naming conventions I'd say. Usually I'm not a fan of having multiple things in one file. It would add the "complexity" of always having to choose if things should be combined or not, naming can become unclear, locating certain things can become more difficult.

In some cases I agree it would make sense to group items but it doesn't way up to the downsides. So I rather keep it consistent