ParchmentMC/Parchment

Incorrect param in `Connection`

Closed this issue · 1 comments

Minecraft version: 1.20.6
Mappings version: 2024.05.01

In the following methods (that I have noticed):

  • initiateServerboundPlayConnection
  • initiateServerboundConnection

The param disconnectListener is incorrect. This is not a listener for just disconnecting but it the initial listener intended to be paired with the initial clientboundProtocol also provided in these methods.

It should be named packetListener

The field is not incorrect though. During handshake, the regular packet listener is also set to this param