Password4j/password4j

Remove the slf4j-nop from compile classpath

sureshg opened this issue · 5 comments

sureshg commented

You shouldn't add the slf4j nop impl to the classpath ( https://github.com/Password4j/password4j/blob/master/pom.xml#L53) as it causing package conflict issues for modular applications. Usually application using this library brings proper slf4j impl.

 error: module dev.xxx.openjdk.playground reads package org.slf4j.impl from both org.slf4j.nop and org.apache.logging.log4j.slf4j
firaja commented

Hi @sureshg,

thank you for pointing that out!
I'm going to remove the slf4j-nop dependency, which you can exclude for the moment in your maven/gradle project.

firaja commented

Merged into master

  • 🎉1
pnacelli commented

@firaja

Thank you for making the change, is this going to be reflected in the maven repo sometime soon as new version? 1.5.4 or 1.6.0?

Cheers

firaja commented

Hello @pnacelli and @sureshg,
I released 1.5.4 to the maven repo with this issue fixed.

  • 🎉2
pnacelli commented

Hi @firaja got your notification, much appreciated!
Have a great weekend! 🙂