Substring throws Exception

Question

Substring throws Exception

robxu9 opened this issue 13 years ago · 5 comments

In Database, the getStatement function can throw an exception if the trimmed query is not of the length expected.
You need to check the size before substringing.

Answer 1 · 2012-04-30T05:28:53.000Z

I read this issue when you first submitted it and I believe I fixed it in a commit that has not been pushed. I'll check when I have the free time to code.

Answer 2 · 2012-04-30T11:27:55.000Z

I fixed it in https://github.com/Minequest/Minequest-Reloaded-Core and also added an H2 version of the library. You can check there if you want.

Answer 3 · 2012-07-26T12:33:57.000Z

... how did I not reply to this? I have a clear recollection of replying to you.

Anyway, could you do me a huge favor and pull request your changes?

https://github.com/PatPeter/SQLibrary/pulls

I'm about to make many edits to the library and do not want them to conflict with your changes (last I worked on this was March).

Answer 4 · 2012-07-30T17:00:51.000Z

Hm, push your changes first. I can always adapt them easily.

Answer 5 · 2012-09-09T22:28:57.000Z

It only took me 6 months, but I finally fixed this issue (finally).

Feel free to push your changes at anytime. I would love that H2 driver.