Bad url search keyword encoding
PaulMcInnis opened this issue · 3 comments
PaulMcInnis commented
Description
We currently pass keywords verbatim, even if they include “+” or other special characters, we should be encoding these so as not to disrupt the url formation.
Steps to Reproduce
- Search with any word containing +s such as “C++”
Expected behavior
We would get a query containing “%” encoded values in place of +s
Actual behavior
We build a search string with erroneous + chars that breaks the search query url (query is not as intended)
Environment
- Build: current dev
- Operating system Ubuntu 18.04
PaulMcInnis commented
We should consider using a library that construct urls for us which handles encoding
PaulMcInnis commented
Marking duplicate #80