PaulTaykalo/swift-scripts

Function type variable and lazy stored properties not detected

Arthur111 opened this issue · 7 comments

Arthur111 commented

You can define a function type variable or a lazy stored property and not using it and your script is blind.

Lazy stored properties

Function type variable

I do not think closing an active bug will solve the problem.

PaulTaykalo commented

Yep.

Again. what exact case are you referencing to?

class A {
	lazy var item: String = ""
}

image

Will leave it here.
https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution

PaulTaykalo commented

@Arthur111 is there any updates on this?

Arthur111 commented

class A
{
static let a = A()
}

class B
{
lazy var c = A.a // you don't use c
}

c is not detected

class D
{
var e: (()->())! // you don't use e
}

e is not detected

So as i said Lazy stored properties and Function type variable are not detected.

Arthur111 commented

Issue not solved.
Some var are used and they are detected.
Some lazy var are not used and not detected.
Some functions var are used and detected.

In other words this script is not usable.

PaulTaykalo commented

@Arthur111 Sure, as soon as there'll be other examples, and some free time I will or will not try or not try to fix. If ever there were a chance for you to fix it. Wait...

PaulTaykalo commented

By the way, there are Hacktoberfest challenge at the moment, so there even more reasons to create a pull request,