Peer5/videojs-contrib-hls.js

README is misleading

jgubman opened this issue · 7 comments

jgubman commented

According to your README, this plugin replaces the official videojs/videojs-contrib-hls
According to them, that's not true: videojs/videojs-contrib-hls#797

gkatsev commented

Heh, thanks. I just wrote #3 as well :D

jgubman commented

👍

gkatsev commented

Quoting what I said in #3 below:

The README here says that it is replacing videojs-contrib-hls. But it is not replacing it. videojs-contrib-hls is still a live project that is being active worked on.
It would be nice if instead it just calls out that it is similar to videojs-contrib-hls.

shacharz commented

Sorry for the confusion, I tried to pass to the reader the notion that he doesn't need both on his page. He can replace the existing contrib-hls on his page if he wishes to. Willing to accept PRs / suggestions

jgubman commented

PR submitted

jgubman commented

Thanks!

shacharz commented

Thank you ;)