Code Cleanup
Opened this issue · 0 comments
bakert commented
Time to clear up lingering warnings and other nonsense in the Gatherling codebase now that we truly own it.
Top 20 issues by count:
discord@katelyngigante:~> cat ~/gatherling.log | grep gatherling.one | cut -d']' -f5- | sed 's/, referer.*//' | sort | uniq -c | sort -rn | head -20
6532 PHP Warning: ini_set(): A session is active. You cannot change the session module's ini settings at this time in /home/discord/public_html/gatherling.one/lib.php on line 43
6532 PHP Warning: ini_set(): A session is active. You cannot change the session module's ini settings at this time in /home/discord/public_html/gatherling.one/lib.php on line 42
FIXED 4218 PHP Warning: Use of undefined constant count - assumed 'count' (this will throw an Error in a future version of PHP) in /home/discord/public_html/gatherling.one/series.php on line 37
784 PHP Notice: Trying to get property 'name' of non-object in /home/discord/public_html/gatherling.one/deck.php on line 404
637 PHP Warning: count(): Parameter must be an array or an object that implements Countable in /home/discord/public_html/gatherling.one/models/Event.php on line 403
290 script '/home/discord/public_html/gatherling.one/wp-login.php' not found or unable to stat
284 PHP Warning: count(): Parameter must be an array or an object that implements Countable in /home/discord/public_html/gatherling.one/models/Event.php on line 408
211 PHP Warning: count(): Parameter must be an array or an object that implements Countable in /home/discord/public_html/gatherling.one/models/Format.php on line 163
50 script '/home/discord/public_html/gatherling.one/xmlrpc.php' not found or unable to stat
34 PHP Notice: Trying to get property 'password' of non-object in /home/discord/public_html/gatherling.one/register.php on line 78
32 PHP Warning: Creating default object from empty value in /home/discord/public_html/gatherling.one/register.php on line 82
28 PHP Fatal error: Uncaught Error: Call to undefined method stdClass::save() in /home/discord/public_html/gatherling.one/register.php:87\nStack trace:\n#0 /home/discord/public_html/gatherling.one/register.php(26): doRegister()\n#1 /home/discord/public_html/gatherling.one/register.php(14): content()\n#2 {main}\n thrown in /home/discord/public_html/gatherling.one/register.php on line 87
19 script '/home/discord/public_html/gatherling.one/admin.php' not found or unable to stat
FIXED 17 PHP Fatal error: Uncaught Error: Call to undefined function mysql_connect() in /home/discord/public_html/gatherling.one/models/Decksearch.php:242\nStack trace:\n#0 /home/discord/public_html/gatherling.one/decksearch.php(347): Decksearch->idsToSortedInfo(Array)\n#1 /home/discord/public_html/gatherling.one/decksearch.php(98): displayDecksFromID(Array)\n#2 /home/discord/public_html/gatherling.one/decksearch.php(14): handleRequest()\n#3 {main}\n thrown in /home/discord/public_html/gatherling.one/models/Decksearch.php on line 242
16 PHP Notice: Undefined index: pkonly in /home/discord/public_html/gatherling.one/event.php on line 1133
12 PHP Notice: Undefined index: mode in /home/discord/public_html/gatherling.one/admin/infobot.php on line 24
11 PHP Notice: Undefined index: mode in /home/discord/public_html/gatherling.one/admin/infobot.php on line 27
8 PHP Warning: strncmp() expects exactly 3 parameters, 2 given in /home/discord/public_html/gatherling.one/admin/infobot.php on line 24
6 PHP Warning: count(): Parameter must be an array or an object that implements Countable in /home/discord/public_html/gatherling.one/models/Event.php on line 405
6 PHP Fatal error: Uncaught Exception: Entry for seky in Penny Dreadful Thursdays 11.07 not found in /home/discord/public_html/gatherling.one/models/Deck.php:585\nStack trace:\n#0 /home/discord/public_html/gatherling.one/deck.php(262): Deck->save()\n#1 /home/discord/public_html/gatherling.one/deck.php(57): insertDeck()\n#2 {main}\n thrown in /home/discord/public_html/gatherling.one/models/Deck.php on line 585