PhoenicisOrg/scripts

Apply Formatting to "script.js" Files

madoar opened this issue · 4 comments

Currently we only apply formatting to our *.json files.
I think it would be specify a required formatting for the script.js files, similar to what we do for the .json files at https://phoenicisorg.github.io/scripts/General/tools/.

I'm currently using

npm install -g prettier
prettier --print-width 120 --use-tabs --write **/script.js

for the installer scripts in #1011. Maybe we could use prettier for the formatting and tweak the parameters a bit more.

@ImperatorS79 @plata @qparis what do you think?

plata commented

ESLint should already do that.

Yes but only on Travis right? I'm basically suggesting a client side solution which the developers can use to format their code. ESlint is not really a formatter but a linter, which helps you analyze the source code.

plata commented

No. You can use --fix (see tools docs).

plata commented

Can we close this?