PhoenicisOrg/scripts

Remove "wizard" from the "preInstall" and "postInstall" Hooks of the Installer Scripts

madoar opened this issue · 1 comments

Currently we pass the two parameters wine (of type Wine) and wizard (of type SetupWizard) to the preInstall and postInstall hooks of the installer scripts. The wizard parameter is redundant because it can also be fetched from wine by calling wine.wizard() therefore we should remove it from both hooks. This will change the syntax of the two hooks to:

Installer.preInstall(wine => {
   ...
});

Installer.postInstall(wine => {
   ...
});

For more details see also #1117 (comment)

plata commented

When fixing this, don't forget documentation.