PhoenixDevTeam/Phoenix-for-VK

Publish app to F-Droid repo

kolya-ay opened this issue · 4 comments

kolya-ay commented

In this case it would be not only the first open-sourced VK client for Android but the only on F-Droid repositories..

IzzySoft commented

@dealnotedev we've several problems building your app at F-Droid:

  • it contains several proprietary libraries which are not accepted at F-Droid, namely Firebase and Crashlytics. Any chance to have a build flavor coming without those?
  • tag name (4.0.0) doesn't match versionName (4) in app/build.gradle. Could you please adjust the latter?

Please let us know if you plan do do the above, so we know how to deal with the issue on our end. Thanks!

  • 👍2
ezorrio commented

@IzzySoft could you attach the whole list of dependencies that has to be removed in order to be approved on F-Droid?

IzzySoft commented

Could you please refer to the linked post? I've listed my findings there (though not being a dev I cannot be sure if I missed something). Copy-Pasting:

    classpath 'com.google.gms:google-services:4.1.0'
    classpath 'io.fabric.tools:gradle:1.25.4'

are no-goes, as are

implementation "com.google.firebase:firebase-core:16.0.5"
implementation "com.google.firebase:firebase-database:16.0.5"
implementation "com.google.firebase:firebase-messaging:17.3.4"
implementation 'com.crashlytics.sdk.android:crashlytics:2.9.6'

Our scanner wouuld be able to give more details, but it said:

INFO: ...skipping version 4.1.0 - Generated by import.py - check/set version fields and commit id

Wondering whether you have deleted tags (thou shalt not do that), as I don't see a 4.1.0 but only a 4.0.0 – so I need to explain that based on the 4.0.0 tag's app/build.gradle:

    versionCode 40031
    versionName '4'

Based on that, the tag should be named 4 or v4. Based on the tag name, it should be versionName '4.0.0' in your gradle (in short: the two must match). So if you could adjust that (e.g. correcting app/build.gradle and then have the matching tag point to that commit), I can tell our bot to scan again.

ezorrio commented

In order to publish to F-Droid we have to remove all GP services dependencies which leads to major code changes that we cannot afford. Closing this for now