Download goes into minus

Question

Download goes into minus

Closed this issue 4 years ago · 29 comments

While downloading the update ,download goes till 50% or 65% and then goes into minus like -65% and decreases to 0 again.

Answer 1 · 2020-12-21T12:14:30.000Z

thanks for your issue, will look into it.

Answer 2 · 2020-12-21T23:22:57.000Z

@MudassirMobi Did you just download the original library code and test it in the sample app?

Answer 3 · 2020-12-22T08:03:44.000Z

@cyb3rko Let me do the same .

Answer 4 · 2020-12-22T09:07:24.000Z

As per your suggestion I downloaded the demo project from GitHub and added my apk url but issue still persists. I have attached the screenshot for your reference. It's showing positive value till 65 and then it decreases to 0 like -65 ,-64.....-1,0.

…

On Tue, Dec 22, 2020, 4:53 AM Niko Diamadis ***@***.***> wrote: @MudassirMobi <https://github.com/MudassirMobi> Did you just download the original library code and test it in the sample app? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZICD3PVFLO3FMGDMNTSV7KF5ANCNFSM4VEDWB3A> .

Answer 5 · 2020-12-22T09:20:40.000Z

Hmm, weird.
Does the download fail or does it download?
I will have to try to implement the library in an own app because since now I just worked directly on the library code.

Answer 6 · 2020-12-22T09:34:10.000Z

App was not working than I have added this line of code in Application tag in Manifest file
" android:requestLegacyExternalStorage="true" " ,for android 10 in your project. And then it works, It gets download, but the progress bar showing nagative values as well ,which is my main concern.

Answer 7 · 2020-12-22T09:39:02.000Z

Ah, so it was the problem with Android 10 okay.
Yeah, adding this line is the much easier way of installing apps on Android 10 or higher, but it's not good practice.
I have not tested it yet on Android 10, I will do it as well and see if I can solve that problem, thanks!

Answer 8 · 2020-12-22T09:39:32.000Z

At some point we will add installer for Android 10.

Answer 9 · 2020-12-22T09:57:56.000Z

Cool, I m also looking to solutions for the same .Lets fix this problem.

…

On Tue, Dec 22, 2020, 3:09 PM Niko Diamadis ***@***.***> wrote: At some point we will add installer for Android 10. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZJICELHCQ7YUVHP7J3SWBSOJANCNFSM4VEDWB3A> .

Answer 10 · 2020-12-22T11:10:16.000Z

I just added System.out.println(progress[0]); in ProgressUpdate of the AsyncTask and ran the app. It just prints out the numbers from 0 to 100.
For me everything seems to work. You can do it too and see what gets printed.

Answer 11 · 2020-12-22T12:08:29.000Z

Yes,but i m running your project and this is logcat while running 2020-12-22 17:34:17.321 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress63% 2020-12-22 17:34:17.335 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress63% 2020-12-22 17:34:17.486 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress63% 2020-12-22 17:34:17.487 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress64% 2020-12-22 17:34:17.756 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress64% 2020-12-22 17:34:17.757 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress65% 2020-12-22 17:34:18.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress65% 2020-12-22 17:34:18.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.390 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.454 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.540 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.541 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-64% 2020-12-22 17:34:19.021 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-64% 2020-12-22 17:34:19.021 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-63% 2020-12-22 17:34:19.461 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-63% 2020-12-22 17:34:19.461 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-62% 2020-12-22 17:34:20.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-62% 2020-12-22 17:34:20.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:20.363 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:21.621 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:21.639 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:21.639 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-60%

…

On Tue, Dec 22, 2020 at 4:40 PM Niko Diamadis ***@***.***> wrote: I just added System.out.println(progress[0]); in ProgressUpdate of the AsyncTask and ran the app. It just prints out the numbers from 0 to 100. For me everything seems to work. You can do it too and see what gets printed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZI7YKHCI43OA5K6OV3SWB5CPANCNFSM4VEDWB3A> .

Answer 12 · 2020-12-22T12:09:58.000Z

Can u mail a zip file of project on which you are testing? On Tue, Dec 22, 2020 at 5:38 PM Mudassir Shaikh <mudassir.s@mobilestyx.co.in> wrote:

…

Yes,but i m running your project and this is logcat while running 2020-12-22 17:34:17.321 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress63% 2020-12-22 17:34:17.335 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress63% 2020-12-22 17:34:17.486 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress63% 2020-12-22 17:34:17.487 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress64% 2020-12-22 17:34:17.756 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress64% 2020-12-22 17:34:17.757 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress65% 2020-12-22 17:34:18.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress65% 2020-12-22 17:34:18.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.390 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.454 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.540 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-65% 2020-12-22 17:34:18.541 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-64% 2020-12-22 17:34:19.021 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-64% 2020-12-22 17:34:19.021 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-63% 2020-12-22 17:34:19.461 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-63% 2020-12-22 17:34:19.461 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-62% 2020-12-22 17:34:20.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-62% 2020-12-22 17:34:20.107 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:20.363 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:21.621 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:21.639 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-61% 2020-12-22 17:34:21.639 21849-21849/com.dcastalia.localapkupdatelibrary E/Progress: Progress-60% On Tue, Dec 22, 2020 at 4:40 PM Niko Diamadis ***@***.***> wrote: > I just added System.out.println(progress[0]); in ProgressUpdate of the > AsyncTask and ran the app. It just prints out the numbers from 0 to 100. > For me everything seems to work. You can do it too and see what gets > printed. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#9 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ASES3ZI7YKHCI43OA5K6OV3SWB5CPANCNFSM4VEDWB3A> > . >

Answer 13 · 2020-12-22T12:12:14.000Z

That's very weird.
I'm just using the code from the master branch.
I also added a Kotlin version of this library (#10), this code also works.

Answer 14 · 2020-12-22T12:48:50.000Z

Thanks, I'll check it out.

…

On Tue, Dec 22, 2020 at 5:42 PM Niko Diamadis ***@***.***> wrote: That's very weird. I'm just using the code from the master branch. I also added a Kotlin version of this library (#10 <#10>), this code also works. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZOJ2MEZFIVSRVXNIQTSWCEK7ANCNFSM4VEDWB3A> .

Answer 15 · 2020-12-22T12:50:34.000Z

Does it try to install the app or does it not trigger the installation process?

Answer 16 · 2020-12-22T14:43:11.000Z

It tries and it download also. The link you provided for apk is from github or from server?

Answer 17 · 2020-12-22T14:44:18.000Z

The problem why the installation fails is because the update is on the same version so you can't update it so I built a new apk:
https://cdn.cyb3rko.de/Apps/testUpdate.apk

Answer 18 · 2020-12-22T14:50:22.000Z

It worked. This apk is already stored on server OR stored on github ? while you provide apk link for downloading in app. Can u tell me please.

…

On Tue, Dec 22, 2020 at 8:14 PM Niko Diamadis ***@***.***> wrote: The problem why the installation fails is because the update is on the same version so you can't update it so I built a new apk: https://cdn.cyb3rko.de/Apps/testUpdate.apk — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZJJPWBYHD4HMJXO3TDSWCWFDANCNFSM4VEDWB3A> .

Answer 19 · 2020-12-22T15:05:39.000Z

What worked? Was the progress shown or did the update succeed?
It's currently stored on my server.

Answer 20 · 2020-12-23T08:47:40.000Z

Both worked. progress and download as well,While i m using your apk link in given sample app. But when I provide my apk link in your sample app then download succeed but progress bar not working properly.

…

On Tue, Dec 22, 2020 at 8:35 PM Niko Diamadis ***@***.***> wrote: What worked? Was the progress shown or did the update succeed? It's currently stored on my server. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZPASSB2ZMWRWN4WKQTSWCYVHANCNFSM4VEDWB3A> .

Answer 21 · 2020-12-23T09:45:40.000Z

I think I will try using the DownloadManager and see if it works better. I'm gonna open a new branch in my forked repo.
I will notify you here if I did it.

Answer 22 · 2020-12-23T09:53:45.000Z

Cool,Thanks .

Answer 23 · 2020-12-24T08:01:44.000Z

Bro it worked ,progress bar showing all positive values till 100 by changing this in your code // int total_size = c.getContentLength();//size of apk float total_size = c.getContentLength();//size of apk Log.e("apk length","total_size" + total_size); byte[] buffer = new byte[1024]; // int len1 = 0; // int per = 0; // int downloaded=0; int len1 = 0; float per = 0; float downloaded=0; while ((len1 = is.read(buffer)) != -1) { fos.write(buffer, 0, len1); downloaded +=len1; // per = (int) (downloaded * 100 / total_size); per = downloaded * 100 / total_size; Log.e("publishprecess","Percent"+per); int Percent = (int) (per) ; // publishProgress(Percent); Log.e("publishprecess","Percent"+per); Changing data types of calculating variables..

…

On Wed, Dec 23, 2020 at 3:15 PM Niko Diamadis ***@***.***> wrote: I think I will try using the DownloadManager and see if it works better. I'm gonna open a new branch in my forked repo. I will notify you here if I did it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZM5SKIJM5FFRH3APJ3SWG35FANCNFSM4VEDWB3A> .

Answer 24 · 2020-12-24T08:02:21.000Z

Thanxx for your help. On Thu, Dec 24, 2020 at 1:31 PM Mudassir Shaikh <mudassir.s@mobilestyx.co.in> wrote:

…

Bro it worked ,progress bar showing all positive values till 100 by changing this in your code // int total_size = c.getContentLength();//size of apk float total_size = c.getContentLength();//size of apk Log.e("apk length","total_size" + total_size); byte[] buffer = new byte[1024]; // int len1 = 0; // int per = 0; // int downloaded=0; int len1 = 0; float per = 0; float downloaded=0; while ((len1 = is.read(buffer)) != -1) { fos.write(buffer, 0, len1); downloaded +=len1; // per = (int) (downloaded * 100 / total_size); per = downloaded * 100 / total_size; Log.e("publishprecess","Percent"+per); int Percent = (int) (per) ; // publishProgress(Percent); Log.e("publishprecess","Percent"+per); Changing data types of calculating variables.. On Wed, Dec 23, 2020 at 3:15 PM Niko Diamadis ***@***.***> wrote: > I think I will try using the DownloadManager and see if it works better. > I'm gonna open a new branch in my forked repo. > I will notify you here if I did it. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#9 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ASES3ZM5SKIJM5FFRH3APJ3SWG35FANCNFSM4VEDWB3A> > . >

Answer 25 · 2020-12-24T08:18:34.000Z

Awesome. Then just open a pull request to fix it for others too.

Answer 26 · 2020-12-25T16:13:50.000Z

@MudassirMobi Or should I do that?

Answer 27 · 2020-12-25T17:33:38.000Z

Yes, you can do that,if u can .it's just small changes

…

On Fri, Dec 25, 2020, 9:44 PM Niko Diamadis ***@***.***> wrote: @MudassirMobi <https://github.com/MudassirMobi> Or should I do that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZKTNGIDXECY74LZCPTSWS24VANCNFSM4VEDWB3A> .

Answer 28 · 2020-12-25T22:50:09.000Z

@MudassirMobi I hope my fix works (see #11)

Answer 29 · 2020-12-26T08:36:19.000Z

Yes ,but I will be available on Monday or Tuesday so than I can

…

On Sat, Dec 26, 2020, 4:20 AM Niko Diamadis ***@***.***> wrote: @MudassirMobi <https://github.com/MudassirMobi> I hope my fix works (see #11 <#11>) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASES3ZKFBGNZUTSA5A6CHRTSWUJK3ANCNFSM4VEDWB3A> .